[Pixelfed] Pictures not loading

Lapineige · May 7, 2023, 8:58pm

It should not be the case.

whitebriar · May 7, 2023, 9:19pm

Yes; I have uploaded and deleted several pictures and, at the time of upgrade, had one image stored on the server for test purposes.

Looks like the rollback didn’t complete correctly and I will have to reinstall the Pixelfed app to troubleshoot further. If you’d like me to take certain steps in doing so, just let me know.

Thanks for all the work being put into this,
-Sam

Lapineige · May 7, 2023, 9:47pm

Ok, that’s strange, that folder should have been created…
If you still have the archive, can you (download &)open it, and see if this folder is present in the folder /etc located somewhere in backup folder ?

Wow that’s too bad, sorry
Do you have the error log ?

whitebriar · May 7, 2023, 10:03pm

Ok, that’s strange, that folder should have been created…
If you still have the archive, can you (download &)open it, and see if this folder is present in the folder /etc located somewhere in backup folder ?

Wow that’s too bad, sorry
Do you have the error log ?

Apologies; from the CLI, I can’t seem to find a backup folder in /etc (I am well out of practice navigating Linux filesystems but I can’t find anywhere that pixelfed backup would be).

I only have the log from the failed upgrade, which is here. If there’s a separate error log, I should be able to find and copy that from the CLI.

I will try to recreate this error with a fresh install and will report if I get the same upgrade failure.

Thanks again,
-Sam

whitebriar · May 8, 2023, 1:25am

To update this issue:

First Stage

Installed a fresh Pixelfed app

Added avatar icon (failed: broken image link)

Created Backup #1

Added Test Image to post (failed: broken image link)

Created Backup #2

Second Stage

Ran Pixelfed test upgrade (failed: “WARNING chmod: cannot access ‘/var/www/pixelfed/public/storage/m/_v2/*’: No such file or directory”)

Reverted to previous installation without problem

Third Stage

Restored Backup #1 (made prior to posting test image)

Ran Pixelfed test upgrade (succeeded)

Added Test Image to post (succeeded)

Avatar link still broken: attempted to upload new avatar image (failed: broken image link)

Fourth Stage

Ran ls -l on /var/www/pixelfed/public/storage/avatars

Folder containing avatar file returned 700 (drwx------)

Ran chmod -R 750 foldername

Avatar image appeared in UI

To summarize, upgrading from a fresh install fixed the image posting issue so long as I didn’t have pre-existing images or folders. Upgrading did not fix the folder permissions for avatar images, though manually changing group permissions did.

Thanks again for all the work. I have backups at various steps if further testing is needed.
-Sam

aarontrom · May 8, 2023, 1:51am

I have this very exact issue too when upgrading to the latest testing branch via sudo yunohost app upgrade pixelfed -u https://github.com/YunoHost-Apps/pixelfed_ynh/tree/testing

Info: [####+...............] > Upgrading NGINX web server configuration...
Info: [#####...............] > Updating composer...
Info: [#####+..............] > Updating composer dependencies...
Info: [######+.............] > Patching permissions (for version 0.11.5 and newer)...
Warning: chmod: cannot access '/var/www/pixelfed/public/storage/m/_v2/*': No such file or directory
Warning: [Error] Upgrade failed.
Warning: The app was restored to the way it was before the failed upgrade.

however, there are 2 folders when I do ls:

ls -lha /var/www/pixelfed/public/storage/m/_v2/
total 16K
drwxr-x---  4 pixelfed www-data 4.0K Jan 30  2022 .
drwxrwx---  3 pixelfed www-data 4.0K May  3 08:30 ..
drwxr-x--- 20 pixelfed www-data 4.0K May  2 02:03 377235678086303745
drwxr-x---  6 pixelfed www-data 4.0K Feb  5 11:32 393356619195998209

Lapineige · May 8, 2023, 7:15am

The backup is in /home/yunohost.backup/archives. The folder I’m searching for is in the .tar archive of the backup.

You could download it from the web admin interface, it would then be easier to search into it from your computer

What is surprising to me is that I test for the presence of such a folder here. And any sub-folder should be created upon user creation or for picture uploaded.

github.com

YunoHost-Apps/pixelfed_ynh/blob/testing/scripts/upgrade#L199


      
          ynh_script_progression --message="Updating composer dependencies..." --weight=1
          ynh_exec_warn_less ynh_composer_exec --workdir="$final_path" --commands="update"
          
          
#=================================================
          # PATCH PERMISSIONS for v0.11.5 versions and higher
          #=================================================
          ynh_script_progression --message="Patching permissions (for version 0.11.5 and newer)..." --weight=1
          # Default configuration doesn't work
          ynh_replace_string --match_string="'private' => 0700," --replace_string="'private' => 0750," --target_file=$final_path/config/filesystems.php
          # Repair permissions for files created after v0.11.5 and before this patch
          if [ -d "$final_path/public/storage/m/_v2/" ]; then
            chmod 750 -R "$final_path/public/storage/m/_v2/*" # all files subdirectories (picture folders) should be readable and executable. But if there is no picture, there is no /*/*
            chmod 770 "$final_path/public/storage/m/_v2/" # this should be 770
            chmod 770 "$final_path/public/storage/m/_v2/*" # users folders should be 770
          fi
          
          
#=================================================
          # DEPLOYMENT
          #=================================================
          ynh_script_progression --message="Deploying..."

Lapineige · May 8, 2023, 7:17am

Can you give me the result of that ls -l command ? Or rather just the user and group that own the file (pixelfed pixelfed, or pixelfed www-data ?).

Lapineige · May 8, 2023, 7:18am

Good catch, I wasn’t aware of an issue for avatars too !

Lapineige · May 8, 2023, 7:28am

And as a result the test I included in the code is valid and it tries… but why does it fails ??

whitebriar · May 8, 2023, 8:38pm

Yes, the readout (with adjusted permissions) is

drwxrwx--- 3 pixelfed www-data 4096 May  7 19:25 avatars

whitebriar · May 8, 2023, 8:56pm

I think this might be a case of placing the wildcard (*) inside the quoted line, rather than outside. “Globbing”, I think, is the term used for the work the wildcard is supposed to do and placing it inside the quotation mark seems to prevent the wildcard from globbing.

If I recreate the code using some test folders I made, this is the result I get by placing the wildcard inside or outside the quotation mark:

root@dragonface:/home/dragonface/test# ls -l

drwxr-xr-x 2 root root 4096 May  8 16:44 Test_1
drwxr-xr-x 2 root root 4096 May  8 16:44 Test_2
drwxr-xr-x 2 root root 4096 May  8 16:44 Test_3

root@dragonface:/home/dragonface/test# cd ..

root@dragonface:/home/dragonface# chmod 700 -R "/home/dragonface/test/*"
chmod: cannot access '/home/dragonface/test/*': No such file or directory

root@dragonface:/home/dragonface# chmod 700 -R "/home/dragonface/test/"*

root@dragonface:/home/dragonface# cd test

root@dragonface:/home/dragonface/test# ls -l

drwx------ 2 root root 4096 May  8 16:44 Test_1
drwx------ 2 root root 4096 May  8 16:44 Test_2
drwx------ 2 root root 4096 May  8 16:44 Test_3

This appears to replicate the error seen when attempting to upgrade the Pixelfed test branch with pre-existing subfolders.

Lapineige · May 8, 2023, 9:05pm

You rocks !
Thanks a lot !

KaraDanvers · May 26, 2023, 7:04am

so excited recent uppdate 0.11.7~ynh1 fixed the issue i can now upload.