[Shellinabox] Little bug in upgrade

[lnoferin]

My YunoHost server

Hardware: Raspberry Pi at home
YunoHost version: 11.1.21.4
I have access to my server : Through SSH | through the webadmin
Are you in a special context or did you perform some particular tweaking on your YunoHost instance ? : no
If your request is related to an app, specify its name and version: shellinabox v2.21~ynh4

Description of my issue

Trying to upgrade to the latest version of the shellinabox I get this error

Info: Deprovisionning install_dir...                                            
Info: Deprovisionning system_user...                                            
userdel: user shellinabox is currently used by process 1679                     
/usr/sbin/deluser: `/sbin/userdel shellinabox' returned error code 8. Exiting.  
Warning: Failed to deprovision system_user : Failed to delete system user for shellinabox                                                                       
Info: Reprovisionning install_dir...                                            
Info: Reprovisionning system_user...                                            
Error: Provisioning, deprovisioning, or updating resources for shellinabox failed: Failed to delete system user for shellinabox                                 
Info: The operation 'Upgrade the 'shellinabox' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230614-183946-app_upgrade-shellinabox' to get help                              
Error: The operation 'Upgrade the 'shellinabox' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230614-183946-app_upgrade-shellinabox' to get help

(The full log is in https://paste.yunohost.org/raw/awohozozun but it does not say almost anything else).

So I tried stopping manually the service before the upgrade but the error remained.

So I remove the package (it does not have quite any data) but it does not work anymore because the relevant configuration for nginx was not installed.

[webmink]

I have the same problems.

My YunoHost server

Hardware: Raspberry Pi at home
YunoHost version: 11.1.24.4
I have access to my server : Through ShellInABox | direct access via keyboard / screen
Are you in a special context or did you perform some particular tweaking on your YunoHost instance ? : no
If your request is related to an app, specify its name and version: shellinabox v2.21-ynh3

Description of my issue

When I accept the offer in System Update to upgrade to 2.21-ynh4 the upgrade fails saying it cannot delete the system user. No instance of Shell or ssh is running.
Log: https://paste.yunohost.org/raw/bubirofuzo

[webmink]

I was able to perform the upgrade by killing the shellinabox daemon, but then when I tried to run ynh4 (after a reboot) the log said:

– Boot 114570f9365c42a19a94e9fbd51f3e72 –
Jun 21 13:01:24 systemd[1]: Starting LSB: Shell In A Box Daemon…
Jun 21 13:01:25 shellinabox[1269]: [server] Cannot look up user id “shellinabox”!
Jun 21 13:01:25 shellinaboxd[1269]: [server] Cannot look up user id “shellinabox”!
Jun 21 13:01:25 shellinaboxd[1269]: [server] Aborting…

I have restored ynh3 and it’s working again.

[aoz]

Same issue on my server:
https://paste.yunohost.org/raw/wuhowasefe

[StraToN]

Same issue on my server.
https://paste.yunohost.org/raw/oyozerigaw

[KaTeznik]

Confirmed on my side : https://paste.yunohost.org/raw/zoxohemesu

[lnoferin]

The issue is also on github: Upgrade fails: from 2.21~ynh3 to 2.21~ynh4 · Issue #36 · YunoHost-Apps/shellinabox_ynh · GitHub

[vvr]

Same for me :

ended_at: 2023-06-28 08:41:19.327164
env:
YNH_APP_ACTION: upgrade
YNH_APP_BASEDIR: /var/cache/yunohost/app_tmp_work_dirs/app_e1f19ug1
YNH_APP_CURRENT_VERSION: 2.21~ynh3
YNH_APP_ID: shellinabox
YNH_APP_INSTANCE_NAME: shellinabox
YNH_APP_INSTANCE_NUMBER: ‘1’
YNH_APP_MANIFEST_VERSION: 2.21~ynh4
YNH_APP_PACKAGING_FORMAT: ‘2.0’
YNH_APP_UPGRADE_TYPE: UPGRADE_PACKAGE
YNH_ARCH: arm64
YNH_DEBIAN_VERSION: bullseye
error: Failed to delete system user for shellinabox
interface: api
operation: app_upgrade
parent: null
related_to:

• • app
  • shellinabox
    started_at: 2023-06-28 08:41:19.028218
    success: false
    yunohost_version: 11.1.21.4

============

2023-06-28 10:41:19,050: INFO - Deprovisionning install_dir…
2023-06-28 10:41:19,052: INFO - Deprovisionning system_user…
2023-06-28 10:41:19,249: WARNING - Failed to deprovision system_user : Failed to delete system user for shellinabox
2023-06-28 10:41:19,250: INFO - Reprovisionning install_dir…
2023-06-28 10:41:19,267: INFO - Reprovisionning system_user…
2023-06-28 10:41:19,325: ERROR - L’allocation automatique des ressources (provisioning), la suppression d’accès à ces ressources (déprovisioning) ou la mise à jour des ressources pour shellinabox a échoué : Failed to delete system user for shellinabox