[Outline] An open, extensible, wiki for your team

sammcf · May 10, 2022, 8:05am

I’m using Chromium 101.0.4951.54, but I also tried in Firefox 100. The sequence unfolds the same in incognito mode, too.

The oidc.callback is setting an accessToken cookie, which is as close as I can see to a token:

accessToken=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6IjBiOWQ1NGI4LWYzNjctNGQ1Ny05YTY2LTI1MmVkZGMzMmZhZiIsInR5cGUiOiJzZXNzaW9uIiwiaWF0IjoxNjUyMTY5MjQyfQ.xuRa6GqRwGctVDhwjiWYnn_7-OAeuxer3dC0cvD64Xw; path=/; expires=Wed, 10 Aug 2022 07:54:02 GMT; secure

/var/log/dex/dex.log:

root@themultiple:/home/sam# cat /var/log/dex/dex.log
time="2022-05-06T08:19:21Z" level=info msg="Dex Version: , Go Version: go1.17.9, Go OS/ARCH: linux amd64"
time="2022-05-06T08:19:21Z" level=info msg="config issuer: https://auth.domain.tld/"
time="2022-05-06T08:19:21Z" level=info msg="config storage: sqlite3"
time="2022-05-06T08:19:21Z" level=info msg="config static client: Outline"
time="2022-05-06T08:19:21Z" level=info msg="config connector: ldap"
time="2022-05-06T08:19:21Z" level=info msg="config refresh tokens rotation enabled: true"
time="2022-05-06T08:19:21Z" level=info msg="keys expired, rotating"
time="2022-05-06T08:19:22Z" level=info msg="keys rotated, next rotation: 2022-05-06 14:19:22.397009397 +0000 UTC"
time="2022-05-06T08:19:22Z" level=info msg="listening (http) on 127.0.0.1:5556"
time="2022-05-06T09:04:32Z" level=info msg="performing ldap search ou=users,dc=yunohost,dc=org sub (&(objectClass=InetOrgPerson)(uid=sam))"
time="2022-05-06T09:04:32Z" level=info msg="username \"sam\" mapped to entry uid=sam,ou=users,dc=yunohost,dc=org"
time="2022-05-06T09:04:32Z" level=info msg="login successful: connector \"ldap\", username=\"sam mcf\", preferred_username=\"\", email=\"sam@domain.tld\", groups=[]"
time="2022-05-06T09:04:56Z" level=info msg="performing ldap search ou=users,dc=yunohost,dc=org sub (&(objectClass=InetOrgPerson)(uid=sam))"
time="2022-05-06T09:04:56Z" level=info msg="username \"sam\" mapped to entry uid=sam,ou=users,dc=yunohost,dc=org"
time="2022-05-06T09:04:56Z" level=info msg="login successful: connector \"ldap\", username=\"sam mcf\", preferred_username=\"\", email=\"sam@domain.tld\", groups=[]"
time="2022-05-06T09:05:20Z" level=info msg="performing ldap search ou=users,dc=yunohost,dc=org sub (&(objectClass=InetOrgPerson)(uid=sam))"
time="2022-05-06T09:05:20Z" level=info msg="username \"sam\" mapped to entry uid=sam,ou=users,dc=yunohost,dc=org"
time="2022-05-06T09:05:20Z" level=info msg="login successful: connector \"ldap\", username=\"sam mcf\", preferred_username=\"\", email=\"sam@domain.tld\", groups=[]"

You can see multiple login attempts here. The Dex log shows a successful login, but it looks like the callback isn’t passing a token to Outline?

I will say that I cannot rule out some sort of bizarre deep system-level misconfiguration - I’ve nursed this server through I think 3 major Debian releases and many Yunohost releases? So it’s possible that this problem will be resolved by a fresh install (which I am going to do anyway because I’m moving the server onto new hardware shortly!) So it may be that we’re chasing a ghost down a rabbit hole too

Limezy · May 10, 2022, 8:11am

Well, I’m kind of worried because @hanthor reported the exact same problem…
So it looks to me more like an unfound yet bug than a config-specific deeply hidden problem…
Indeed the problem seems to be at the moment the callback is passing a token to Outline.

Just to be sure : are all your domains publicly accessible ? Or is Outline behind the SSO ?

Limezy · May 10, 2022, 8:23am

Yes ! I could reproduce the loop !
Apparently Outline can’t be used behind the SSO as per the current version of the package.
I should remove the option for it to be public or not before I find a way to make it usable…

So you should only have to add “visitors” permission to the Outline app and then should be good to go !

tituspijean · May 10, 2022, 9:17am

Maybe try the SSO with the auth_header permission option set to false?

ynh_permission_url --permission "main" --auth_header=false

(no idea if that will actually help )

Limezy · May 10, 2022, 9:19am

Hi @tituspijean many thanks for your help !
Is there a way to quickly check this without pushing a commit to my repo and install Outline again ?

EDIT : OK did it anyway, now trying to install on my test server

Limezy · May 10, 2022, 10:02am

New update ! Version 0.63.0~ynh3 fixes the private install problem.
@sammcf and @hanthor you can update your Outline installation and it should be good.

sammcf · May 11, 2022, 6:33am

Hah! I never even thought of that…I always install (most) apps privately without thinking about it cos the server lives on the public internet and gets a reasonable amount of anonymous traffic. I’ll try changing that permission just out of curiosity before I update.

Thanks so much for your help @Limezy, it is very much appreciated

Limezy · May 11, 2022, 3:54pm

You are welcome of course.
Outline is really a nice piece of software and it clearly deserved to be packaged for Ynh !

Limezy · May 28, 2022, 4:37am

New stable release ! Shipped version: 0.64.3~ynh1
Upstream changelog

Limezy · June 1, 2022, 5:27am

Now that the Outline package is up and running, should we move that thread to the /announcement/apps part of the forum ?

FreeS · August 19, 2022, 8:53am

Hi,
Can’t make a backup with Yunohost.
The first error I found in the log:

2022-08-18 23:16:05,783: WARNING - mv: cannot move '/var/www/minio/mc/outlinestorage' to '/var/www/outline/outlinestorage/outlinestorage': Directory not empty

When I try to make a backup again:

2022-08-19 07:54:43,664: DEBUG - mkdir: cannot create directory ‘outlinestorage’: File exists
2022-08-19 07:54:43,665: DEBUG - + ynh_exit_properly
2022-08-19 07:54:44,177: DEBUG - + ynh_clean_setup
2022-08-19 07:54:44,177: DEBUG - + true
2022-08-19 07:54:45,183: DEBUG - Не вдалося запустити скрипт: /var/cache/yunohost/app_tmp_work_dirs/app_8gyktktw/scripts/backup - (Failed to run the script)
2022-08-19 07:54:45,185: ERROR - Не вдалося створити резервну копію outline - (Failed to make a backup)

Limezy · August 20, 2022, 8:03am

Hi ! Thanks for your report.
I think I know what’s happening.
Give me a few days to correct

FreeS · August 20, 2022, 9:56am

зображення

Maybe this will help.
There is “outlinestorage” folder with “avatars”, “uploads” inside and another “outlinestorage” with “avatars”, “uploads” in it.

luker · August 22, 2022, 11:29am

Hello,
I had tried to update outline app, but it failed because the backup wasn’t successful.
I got a similar error as @FreeS
Thanks for your help.

Limezy · August 22, 2022, 1:05pm

Fix on the way

Limezy · August 23, 2022, 1:18am

@FreeS @luker the fix has been merged, and now in the queue for apps CI.

You can either wait for a few hours (or days?) to have the update to v0.65.2~ynh2 available in your admin interface, either run the fix manually :
sudo yunohost app upgrade outline -u https://github.com/YunoHost-Apps/outline_ynh --debug

Thanks again for reporting the bug !

luker · August 23, 2022, 1:26pm

Thanks.
I tried running the command but it still failed
Here are the logs
https://paste.yunohost.org/raw/axovulecaw

Limezy · August 24, 2022, 12:48am

That’s strange !

Do you have a working outline app on your Yunohost right now or not ? If yes, which version is it ? If yes, can you upload images to your documents ?

Is your Minio domain secured with a SSL certificate ?

It seems that when you have installed Outline you have passed as Minio domain a domain not yet secured by SSL, which should prevent both the images and attachements to work properly, and the Outline backup to be done.

If that’s the case, I should think about integrating a failsafe here with a warning, but it shouldn’t go as far as crashing the backup !

emilien · August 25, 2022, 9:55am

Bonjour,

Many thanks to make this works with Yunohost but I cant log in outline :
waterfox_ohqjJgkzvr

What I do wrong ?

Limezy · August 25, 2022, 11:58am

Apparently nothing !

Did you try to clear your browser cache ?
Is it your first install or have you already managed to log in before ?