AdGuard Home Upgrade Failed

lordmat · March 21, 2025, 7:17am

What type of hardware are you using: Old laptop or computer
What YunoHost version are you running: 12.1.2
What app is this about: adguardhome

Describe your issue

I am experiencing an issue while updating AdGuard Home (adguardhome) from version 0.107.57~ynh1 to 0.107.58~ynh1. The update process fails with the following error message:

2025-03-21 07:40:58,020: DEBUG - File “/usr/lib/python3/dist-packages/yunohost/firewall.py”, line 101, in _validate_port
2025-03-21 07:40:58,020: DEBUG - raise ValueError(f"protocol should be tcp or udp, not {protocol}")
2025-03-21 07:40:58,020: DEBUG - ValueError: protocol should be tcp or udp, not both.
I have uploaded the full log file.

Currently, my firewall settings for AdGuard Home have both TCP and UDP protocols open on port 853. Additionally, I am unable to modify the port settings within the firewall configuration.

Could you please assist me in resolving this update issue?

Share relevant logs or error messages

https://paste.yunohost.org/raw/roqodaqeli

OniriCorpe · March 21, 2025, 8:25am

Hi and welcome in the YunoHost community!

Shit happens when using testing builds (12.1.x)
The fix for this bug should be available in the next testing update

github.com/YunoHost/yunohost

Fix "Both" protocol for firewall allow/disallow

dev ← fix_firewall_allow_disallow_both

opened 11:34AM - 15 Mar 25 UTC

kay0u

+14 -4

## The problem "Both" is not accepted for the cmd: `yunohost firewall allo…w Both 1234" ``` ❯ sudo yunohost firewall allow Both 1234 Traceback (most recent call last): File "/usr/bin/yunohost", line 108, in <module> main() File "/usr/bin/yunohost", line 97, in main yunohost.cli( File "/usr/lib/python3/dist-packages/yunohost/__init__.py", line 41, in cli ret = moulinette.cli( ^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/moulinette/__init__.py", line 140, in cli ).run(args, output_as=output_as, timeout=timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/moulinette/interfaces/cli.py", line 521, in run ret = self.actionsmap.process(args, timeout=timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/moulinette/actionsmap.py", line 579, in process return func(**arguments) ^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/yunohost/firewall.py", line 461, in firewall_allow return firewall_open( ^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/yunohost/firewall.py", line 405, in firewall_open firewall.open_port(protocol, port, comment, upnp) File "/usr/lib/python3/dist-packages/yunohost/firewall.py", line 107, in open_port protocol, port = self._validate_port(protocol, port) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/yunohost/firewall.py", line 101, in _validate_port raise ValueError(f"protocol should be tcp or udp, not {protocol}") ValueError: protocol should be tcp or udp, not both ``` ## Solution ... ## PR Status Yolo commit ## How to test ...

lordmat · March 21, 2025, 9:06am

Thanks for the info and for welcoming me to the community! Good to know testing builds have their quirks. Will patiently wait for the update to fix AdGuard Home’s stubborn firewall settings. If they’re still rebelling after, I’ll report back. Until then, I’ll try to keep my devices calm – hopefully without any port-freedom demos. Thanks!

OniriCorpe · March 23, 2025, 10:34am

the update you’re waiting for is available ^w^

lordmat · March 27, 2025, 7:21am

Woohoo! The glorious update wave has finally rolled in and successfully tamed AdGuard Home’s stubborn firewall settings! I can confirm: the issue is resolved, and my digital home is once again safe from unwanted guests – all without any rebellious port-freedom demos from my devices.

A huge thank you again for the swift problem-solving! You guys are the heroes of my digital everyday life. If I can ever shower you with virtual flowers or light a digital celebratory bonfire, just let me know! ^w^