# Are Code Reviews Suggested For Changes To Packages?

**URL:** <https://forum.yunohost.org/t/are-code-reviews-suggested-for-changes-to-packages/17091>\
**Category:** Apps packaging\
**Tags:** english\
**Created:** [September 8, 2021, 8:33am UTC](https://forum.yunohost.org/t/are-code-reviews-suggested-for-changes-to-packages/17091 "2021-09-08T08:33:33Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![notplants](https://forum.yunohost.org/user_avatar/forum.yunohost.org/notplants/32/4875_2.png) [@notplants](https://forum.yunohost.org/u/notplants)\
**Post date:** [September 8, 2021, 8:33am UTC](https://forum.yunohost.org/t/are-code-reviews-suggested-for-changes-to-packages/17091/1 "2021-09-08T08:33:34Z")

</div>

Hi all, I was wondering, if I make a pull request to a ynh package I am maintaining, is it expected to find someone to code review it?

or if it passes the tests should I just merge it in?

---

<div class="post-metadata">

**Author:** ![tituspijean](https://forum.yunohost.org/user_avatar/forum.yunohost.org/tituspijean/32/3584_2.png) [@tituspijean](https://forum.yunohost.org/u/tituspijean)\
**Post date:** [September 8, 2021, 8:39am UTC](https://forum.yunohost.org/t/are-code-reviews-suggested-for-changes-to-packages/17091/2 "2021-09-08T08:39:54Z")

</div>

It is up to you, you can ping members of the YunoHost-Apps group or any willing contributor if you want to have a second opinion on your code. The whole point of the group is to have recurrent and reliable people to help packagers. 🙂

If you are confident enough in what your committed and that the tests pass, you can also merge it yourself. 😉

---

<div class="post-metadata">

**Author:** ![notplants](https://forum.yunohost.org/user_avatar/forum.yunohost.org/notplants/32/4875_2.png) [@notplants](https://forum.yunohost.org/u/notplants)\
**Post date:** [September 8, 2021, 8:48am UTC](https://forum.yunohost.org/t/are-code-reviews-suggested-for-changes-to-packages/17091/3 "2021-09-08T08:48:44Z")

</div>

@tituspijean cool good to know!

This particular time, I feel confident in the code changes, but would be curious if someone has an opinion on the changes to systemd permissions, if someone seeing this can take a look [Add support for chromium-based archivebox snapshots by mhfowler · Pull Request #6 · YunoHost-Apps/archivebox\_ynh · GitHub](https://github.com/YunoHost-Apps/archivebox_ynh/pull/6)
